From: Manikantan Ramadas (mramadas@masaka.cs.ohiou.edu)
Date: 01/04/06
Message-Id: <DC3C7192-88B9-4B2E-9721-E935DF531237@irg.cs.ohiou.edu> From: Manikantan Ramadas <mramadas@masaka.cs.ohiou.edu> Subject: Re: tcptrace-bugs Static variable returns of HostName() are not consider by callers Date: Wed, 4 Jan 2006 12:57:46 -0500
>
>> Every where else where HostName() gets called, it is merely
>> for debug-help printf messages;
>
> I agree, the hazard is there but it is ignored only in few debug
> printf()
> (AFAIK). It really *did* manifest as wrong behavior that made
> debugging of
> another bug in 6.6.1 (when dst_port==src_port, seems to be fixed
> now in
> 6.6.7) a lot harder until I fixed the printf()s... It's not nice
> though
> suggesting that debugging printf()s are allowed to mislead, which was
> the case in this instance...
I was under the impression that no one ran into a manifestation
of this wrong behavior (by which I mean incorrect debug printfs), and
therefore took the stance of why fix things if they aren't broken.
But I take your word on this one. The easiset fix would be to wrap up
those HostName() calls in strdup() in those debug printfs. Should be
easy to do. I shall do that for the long over-due next bugfix release
of tcptrace.
Thanks,
Mani.
-- "The quieter you become, the more you can hear." - Baba Ram Dass. ____________________________________________________________________ * Manikantan Ramadas * IRG, OU * http://irg.cs.ohiou.edu/~mramadas * ____________________________________________________________________
This archive was generated by hypermail 2.1.7 : 01/05/06 EST