From: Francesco Vacirca (francesco@net.infocom.uniroma1.it)
Date: 02/11/05
Message-ID: <420C9227.7020408@net.infocom.uniroma1.it> Date: Fri, 11 Feb 2005 12:08:23 +0100 From: Francesco Vacirca <francesco@net.infocom.uniroma1.it> Subject: tcptrace-bugs some memory bugs
Dear all,
I'm working with tcptrace with very large traces and I found that there
are some memory deallocation error in the pool.c and in the avl.c files.
In particular:
- in function PoolFree in the pool.c file, when a pool list is NULL
tcptrace forgets to increase the block number and it loses a block of
memory...
if (pools[poolid].list == NULL) {
block->next = NULL;
pools[poolid].block_no++; <-------------ADDED
pools[poolid].list = block;
return;
}
- in the file avl.c, when tcptrace removes a ptp_snap from the tree it
forgets to deallocate the memory.
In the SnapRemove function it should be added FreePtpSnap(*root);
before *root=NULL; at the end of the function.
In the SnapFindHighest and SnapFindLowest at the end of the
functions it should be added a FreePtpSnap(tmp);
Let me know what you think about these patches.
Francesco
This archive was generated by hypermail 2.1.7 : 02/11/05 EST