From: Wesley Eddy (weddy@elitists.net)
Date: 09/24/03
Date: Wed, 24 Sep 2003 12:40:59 -0400 From: Wesley Eddy <weddy@elitists.net> Subject: tcptrace-bugs [owner-tcptrace@tcptrace.org: BOUNCE tcptrace@tcptrace.org: Non-member submission from [ulisses@pusa.informat.uv.es]] Message-ID: <20030924164059.GD8819@irg.cs.ohiou.edu>
----- Forwarded message from owner-tcptrace@tcptrace.org -----
Date: Wed, 24 Sep 2003 05:28:19 -0400 (EDT)
X-Authentication-Warning: masaka.cs.ohiou.edu: majordomo set sender to owner-tcptrace@tcptrace.org using -f
To: tcptrace-approval@tcptrace.org
From: owner-tcptrace@tcptrace.org
Subject: BOUNCE tcptrace@tcptrace.org: Non-member submission from [ulisses@pusa.informat.uv.es]
X-Spam-Status: No, hits=-5.2 required=5.0
tests=BAYES_01,NO_REAL_NAME,PATCH_UNIFIED_DIFF,X_AUTH_WARNING
version=2.55
X-Spam-Level:
X-Spam-Checker-Version: SpamAssassin 2.55 (1.174.2.19-2003-05-19-exp)
>From weddy Wed Sep 24 05:28:18 2003
Received: from pusa.informat.uv.es (mail@pusa.informat.uv.es [147.156.10.98])
by masaka.cs.ohiou.edu (8.12.10/8.12.8) with ESMTP id h8O9SIGj025230
for <tcptrace@tcptrace.org>; Wed, 24 Sep 2003 05:28:18 -0400 (EDT)
Received: from ulisses by pusa.informat.uv.es with local (Exim 3.35 #1 (Debian))
id 1A25wS-0007Fa-00; Wed, 24 Sep 2003 11:28:12 +0200
Date: Wed, 24 Sep 2003 11:28:12 +0200
From: ulisses@pusa.informat.uv.es
To: tcptrace@tcptrace.org
Subject: Re: bug in RTT 3WHS code
Message-ID: <20030924092812.GA25019@pusa.informat.uv.es>
References: <20030924070842.GA13442@pusa.informat.uv.es> <20030924082532.GB13442@pusa.informat.uv.es>
Mime-Version: 1.0
Content-Type: text/plain; charset=iso-8859-1
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <20030924082532.GB13442@pusa.informat.uv.es>
User-Agent: Mutt/1.3.28i
Hi all again
On Wed, Sep 24, 2003 at 10:25:32AM +0200, ulisses@pusa.informat.uv.es wrote:
[...]
> I patch will be posted soon
^^^
Here is THE patch :-)
I have made some regression tests with big dumps and everything seems ok
Ulisses
Debian GNU/Linux: a dream come true
-----------------------------------------------------------------------------
"Computers are useless. They can only give answers." Pablo Picasso
---> Visita http://www.valux.org/ para saber acerca de la <---
---> Asociación Valenciana de Usuarios de Linux <---
--- tcptrace-6.4.2.orig/trace.c Tue Sep 16 08:19:48 2003
+++ tcptrace-6.4.2-debugged/trace.c Wed Sep 24 09:24:29 2003
@@ -1533,21 +1533,25 @@
if (SYN_SET(ptcp) || FIN_SET(ptcp) || tcp_data_length > 0) {
int len = tcp_data_length;
int retrans_cnt=0;
if (SYN_SET(ptcp)) ++len;
if (FIN_SET(ptcp)) ++len;
/* Don't consider for rexmit, if the send window is 0 */
/* We are probably doing window probing.. */
- if(otherdir->win_last==0 && otherdir->packets > 0){
+ /* Ulisses Alonso Camaro: but... not for the SYN... */
+ /* or one RTT of 3WHS will not be ok because not calling */
+ /* whichquadrant() properly, see my posts in of 24/09/2003 */
+
+ if((otherdir->win_last==0) && (otherdir->packets > 0) && (!SYN_SET(ptcp))){
probe=TRUE;
thisdir->num_zwnd_probes++;
thisdir->zwnd_probe_bytes += tcp_data_length;
}
else
retrans_cnt = retrans_num_bytes = rexmit(thisdir,start, len, &out_order);
if (out_order)
++thisdir->out_order_pkts;
----- End forwarded message -----
This archive was generated by hypermail 2.1.7 : 09/25/03 EDT