Re: tcptrace [PATCH] rwin line on owin plot

From: Manikantan Ramadas (mramadas@masaka.cs.ohiou.edu)
Date: 10/29/03 

Date: Wed, 29 Oct 2003 21:08:42 -0500
From: Manikantan Ramadas <mramadas@masaka.cs.ohiou.edu>
Subject: Re: tcptrace [PATCH] rwin line on owin plot
Message-ID: <20031030020842.GA8330@irg.cs.ohiou.edu>

Hi John,

  Thanks for the patch and my apologies for the delay in response.
  
  I shall be patching it in soon. I was thinking of making the rwin
line show up as yellow instead of orange however, so the contrast from the
red owin line is better.

Thanks,
Mani.

On Fri, Oct 24, 2003 at 10:54:34AM -0400, John Heffner wrote:
> I've found it useful to see an rwin line on the owin plot, and thought
> perhaps other might, too.
>
> -John
>
>
> Index: tcptrace.h
> ===================================================================
> RCS file: /cvsroot/tcptrace/tcptrace.h,v
> retrieving revision 5.70
> diff -U3 -r5.70 tcptrace.h
> --- tcptrace.h 20 Aug 2003 18:09:43 -0000 5.70
> +++ tcptrace.h 24 Oct 2003 14:44:34 -0000
> @@ -471,6 +471,7 @@
> /* Congestion window graph */
> PLOTTER owin_plotter;
> PLINE owin_line;
> + PLINE rwin_line;
> PLINE owin_avg_line;
> PLINE owin_wavg_line;
>
> Index: trace.c
> ===================================================================
> RCS file: /cvsroot/tcptrace/trace.c,v
> retrieving revision 5.65
> diff -U3 -r5.65 trace.c
> --- trace.c 7 Oct 2003 18:57:41 -0000 5.65
> +++ trace.c 24 Oct 2003 14:44:34 -0000
> @@ -534,6 +534,10 @@
> new_line(ptp->a2b.owin_plotter, "owin", "red");
> ptp->b2a.owin_line =
> new_line(ptp->b2a.owin_plotter, "owin", "red");
> + ptp->a2b.rwin_line =
> + new_line(ptp->a2b.owin_plotter, "rwin", "orange");
> + ptp->b2a.rwin_line =
> + new_line(ptp->b2a.owin_plotter, "rwin", "orange");
> ptp->a2b.owin_avg_line =
> new_line(ptp->a2b.owin_plotter, "avg owin", "blue");
> ptp->b2a.owin_avg_line =
> @@ -1150,6 +1154,9 @@
> if (ptp->a2b.owin_line) {
> free(ptp->a2b.owin_line);
> }
> + if (ptp->a2b.rwin_line) {
> + free(ptp->a2b.rwin_line);
> + }
> if (ptp->a2b.owin_avg_line) {
> free(ptp->a2b.owin_avg_line);
> }
> @@ -1159,6 +1166,9 @@
> if (ptp->b2a.owin_line) {
> free(ptp->b2a.owin_line);
> }
> + if (ptp->b2a.rwin_line) {
> + free(ptp->b2a.rwin_line);
> + }
> if (ptp->b2a.owin_avg_line) {
> free(ptp->b2a.owin_avg_line);
> }
> @@ -2282,6 +2292,7 @@
> /* graph owin */
> if (thisdir->owin_plotter != NO_PLOTTER) {
> extend_line(thisdir->owin_line, current_time, owin);
> + extend_line(thisdir->rwin_line, current_time, otherdir->win_last);
> extend_line(thisdir->owin_avg_line, current_time,
> (thisdir->owin_count?(thisdir->owin_tot/thisdir->owin_count):0));
> }
>
> ----------------------------------------------------------------------------
> To unsubscribe, send a message with body containing "unsubscribe tcptrace" to
> majordomo@tcptrace.org. 

-- 
"Strength does not come from physical capacity. It comes from an
indomitable will."                              - Mahatma Gandhi
____________________________________________________________________
  
* Manikantan Ramadas * IRG, OU * http://irg.cs.ohiou.edu/~mramadas *
____________________________________________________________________

----------------------------------------------------------------------------
To unsubscribe, send a message with body containing "unsubscribe tcptrace" to
majordomo@tcptrace.org.

This archive was generated by hypermail 2.1.7 : 10/30/03 EST