Message-ID: <003d01c239da$ecd1c760$f23315ac@mmlad.yrp.nttdocomo.co.jp> From: "Daikichi Osuga" <osuga@mml.yrp.nttdocomo.co.jp> Subject: tcptrace-bugs Fix for "FIN with data" and "RST_IN relative offset" Date: Fri, 2 Aug 2002 13:13:13 +0900
Hello,
Case of FIN with data, Only FIN is plotted, data isn't drawed.
Both FIN and data should be plotted.
RST_IN relative offset is calcurated based on incorrect sequence space.
-- Daikichi Osuga*** tcptrace-6.2.0/trace.c 2002/08/02 02:10:51 --- trace.c 2002/08/02 02:24:34 *************** *** 1654,1660 **** plotter_line(from_tsgpl, current_time, SeqRep(thisdir,start), current_time, SeqRep(thisdir,start+1)); ! } else if (FIN_SET(ptcp)) { /* FIN */ /* we'll plot the FIN from 'end' to 'end+1' because the segment might have data in it too (normally not) */ plotter_perm_color(from_tsgpl, --- 1654,1661 ---- plotter_line(from_tsgpl, current_time, SeqRep(thisdir,start), current_time, SeqRep(thisdir,start+1)); ! } ! if (FIN_SET(ptcp)) { /* FIN */ /* we'll plot the FIN from 'end' to 'end+1' because the segment might have data in it too (normally not) */ plotter_perm_color(from_tsgpl, *************** *** 1672,1682 **** plotter_line(from_tsgpl, current_time, SeqRep(thisdir,end), current_time, SeqRep(thisdir,end+1)); ! } else if (tcp_data_length > 0) { /* DATA */ if (hw_dup) { plotter_perm_color(from_tsgpl, hw_dup_color); } else if (retrans) { plotter_perm_color(from_tsgpl, retrans_color); } plotter_darrow(from_tsgpl, current_time, SeqRep(thisdir,start)); if (PUSH_SET(ptcp)) { --- 1673,1686 ---- plotter_line(from_tsgpl, current_time, SeqRep(thisdir,end), current_time, SeqRep(thisdir,end+1)); ! } ! if (tcp_data_length > 0) { /* DATA */ if (hw_dup) { plotter_perm_color(from_tsgpl, hw_dup_color); } else if (retrans) { plotter_perm_color(from_tsgpl, retrans_color); + } else if (SYN_SET(ptcp) || FIN_SET(ptcp)) { /* back to default color */ + plotter_perm_color(from_tsgpl, default_color); } plotter_darrow(from_tsgpl, current_time, SeqRep(thisdir,start)); if (PUSH_SET(ptcp)) { *************** *** 1874,1880 **** if (to_tsgpl != NO_PLOTTER) { plotter_temp_color(to_tsgpl, text_color); plotter_text(to_tsgpl, ! current_time, SeqRep(thisdir,plot_at), "a", "RST_IN"); } if (from_tsgpl != NO_PLOTTER) { --- 1878,1884 ---- if (to_tsgpl != NO_PLOTTER) { plotter_temp_color(to_tsgpl, text_color); plotter_text(to_tsgpl, ! current_time, SeqRep(otherdir,plot_at), "a", "RST_IN"); } if (from_tsgpl != NO_PLOTTER) {
This archive was generated by hypermail 2b30 : 08/02/02 EDT